Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Damage - Pass ammo to wound handlers #10573

Merged
merged 9 commits into from
Feb 8, 2025

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title.

Potentially breaking change, added note on wiki on best practice, should have a warning on release announcement.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added impact/large kind/change Release Notes: **CHANGED:** labels Dec 19, 2024
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Dec 19, 2024
@LinkIsGrim LinkIsGrim modified the milestones: Ongoing, 3.19.1 Feb 3, 2025
@LinkIsGrim LinkIsGrim merged commit a6befd7 into master Feb 8, 2025
3 checks passed
@LinkIsGrim LinkIsGrim deleted the medical-customWoundHandlers-passAmmo branch February 8, 2025 22:34

// If invalid return, log an error and exit
if (isNil "_damageData" || {!(_damageData isEqualType [])} || {(count _damageData) < _originalCount}) then {
ERROR_2("Return for handler '%1' invalid - '%2', skipping wound handling",_damageData,_handlerName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LinkIsGrim This is now throwing
12:19:40 [ACE] (medical_damage) ERROR: Return for handler '[]' invalid - 'ace_medical_damage', skipping wound handling, need to find a solution to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/large kind/change Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants